Ticket #99 (closed enhancement: fixed)

Opened 1 year ago

Last modified 1 year ago

action should delete the map reference

Reported by: tschaub Assigned to:
Priority: major Milestone: 0.5
Component: GeoExt.Action Version: SVN
Keywords: Cc:
State: Commit

Description

Currently, GeoExt.Action does not have a reference to the control provided in the config. It does however have a reference to the map. I can't immediately see why this is a problem, but it seems like it could be a source of problems at some point. In any case, until we need it, let's delete it.

Attachments

99.patch (1.7 kB) - added by tschaub on 06/18/09 18:30:40.
delete map reference

Change History

06/18/09 18:30:40 changed by tschaub

  • attachment 99.patch added.

delete map reference

06/18/09 18:31:08 changed by tschaub

  • owner changed.
  • state changed from None to Review.
  • component changed from widgets to widgets.Action.

06/19/09 11:04:50 changed by ahocevar

  • state changed from Review to Commit.

Looking at the Ext JS source, I see that there is only one instance where something is deleted from the config: data in Ext.data.Store. But since initialConfig is not a public property in Ext, I guess it is safe to delete objects from it. In the future, we should at least not delete simple type values from the config, since these do not do any harm and it seems to be the ext way of things to find the initial configuration in initialConfig.

Anyway, in this case I agree with Tim. Please commit.

06/19/09 17:15:05 changed by tschaub

  • status changed from new to closed.
  • resolution set to fixed.

(In [1116]) Removing the action's reference to the map. At some point, we may revisit this. It could be useful to have the map reference on the initalConfig. Since the initialConfig of a GeoExt.Action cannot currently be used to create another action, the properties there are not of any use. r=ahocevar (closes #99)