Ticket #89 (closed enhancement: fixed)

Opened 1 year ago

Last modified 1 year ago

[ZoomSlider] ability to choose the event.

Reported by: fredj Assigned to: fredj
Priority: minor Milestone:
Component: GeoExt.ZoomSlider Version: SVN
Keywords: Cc:
State: Commit

Description

Add an option to the widget to let the user choose which event will trigger the zoom.

The possible values are 'changecomplete' (the actual behavior) or 'change' (zoom as soon as the slider is dragged).

Attachments

89.0.patch (1.8 kB) - added by fredj on 06/11/09 16:42:00.
add new zoomEvent option, update example
89.1.patch (2.0 kB) - added by fredj on 06/12/09 12:36:58.
as suggested by ahocevar: change the zoomEvent property to aggressive (boolean)
geoext-89.patch (3.4 kB) - added by ahocevar on 06/12/09 16:49:53.
with tests

Change History

06/11/09 16:42:00 changed by fredj

  • attachment 89.0.patch added.

add new zoomEvent option, update example

06/12/09 09:02:23 changed by fredj

  • state changed from None to Review.

please review.

06/12/09 10:58:43 changed by fredj

  • state changed from Review to None.

'zoomEvent' property name is bad: I want to have the same name (and behavior) between this widget and the 'opacity slider': is triggerEvent better ?

06/12/09 11:44:28 changed by ahocevar

I would not expose the event to the API. Instead, I would give the user an option, say aggressive, to choose whether zooming should occur while dragging (event: change, aggressive: true) or after dragging (event: changecomplete, aggressive: false - default).

06/12/09 12:36:58 changed by fredj

  • attachment 89.1.patch added.

as suggested by ahocevar: change the zoomEvent property to aggressive (boolean)

06/12/09 16:08:37 changed by fredj

  • state changed from None to Review.

06/12/09 16:49:53 changed by ahocevar

  • attachment geoext-89.patch added.

with tests

06/12/09 16:51:02 changed by ahocevar

  • state changed from Review to Commit.

fredj: I added unit tests and made a stricter check (aggressive === true) in my patch. Tests pass in FF3. Please commit.

06/15/09 08:31:37 changed by fredj

  • status changed from new to closed.
  • resolution set to fixed.

(In [1078]) zoom slider: add a new 'aggressive' option to choose which slider event will zoom the map. If aggressive is true the map will zoom when the thumb is moved, else the map is zoomed when the thumb is released (default). Thanks ahocevar for the review and unit test. (closes #89)