Ticket #86 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

legend panel and layer container don't handle multiple record additions properly

Reported by: tschaub Assigned to:
Priority: major Milestone: 0.5
Component: widgets Version: SVN
Keywords: Cc:
State: Commit

Attachments

86.patch (5.9 kB) - added by tschaub on 06/10/09 19:35:09.
handle multiple record additions

Change History

06/10/09 01:28:28 changed by tschaub

Needs some tests, but this is all I can take for now.

06/10/09 02:15:56 changed by tschaub

  • state changed from None to Needs more work.

This fix is not good yet. In addition, there are issues here if we try to map.destroy().

06/10/09 19:35:09 changed by tschaub

  • attachment 86.patch added.

handle multiple record additions

06/10/09 19:38:13 changed by tschaub

  • state changed from Needs more work to Review.

This is ready for review. Adding map.destroy revealed a separate issue with the layer store. I'll ticket this separately.

With this patch, you can add multiple records to a store (with a single add call) and the legend and layer container behave properly.

Tests pass in FF3 and Safari.

06/10/09 21:06:07 changed by tschaub

The map.destroy issue may or may not be #88.

06/11/09 17:08:55 changed by tcoulter

  • state changed from Review to Commit.

This all looks good to me. Marking commit.

06/11/09 20:10:24 changed by tschaub

  • status changed from new to closed.
  • resolution set to fixed.

(In [1045]) Correcting the store add listeners so they properly order things when multiple records are added at once. r=tcoulter (closes #86)