Ticket #85 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

LayerRecord title field is not updated when layer.setName is called

Reported by: tschaub Assigned to:
Priority: major Milestone: 0.5
Component: GeoExt.data.LayerStore Version: SVN
Keywords: Cc:
State: Commit

Description

We are duplicating the layer.name value (as record.get('title')). We should decide whether it makes sense 1) not to duplicate this data, 2) to synchronize the values, or 3) to document that if you set one, you also need to set the other.

Attachments

geoext-85.patch (2.4 kB) - added by ahocevar on 06/11/09 14:19:08.
sync record title and layer name

Change History

06/11/09 14:14:59 changed by ahocevar

  • state changed from None to Review.

I think that the records should have a title to identify the layer, otherwise displaying layers in a grid showing some meaningful name will mean extra affort on the app level. I also think that record title and layer name should be synced. The above patch does this. Tests pass in FF3. Please review.

06/11/09 14:19:08 changed by ahocevar

  • attachment geoext-85.patch added.

sync record title and layer name

06/11/09 16:46:15 changed by elemoine

  • state changed from Review to Commit.

I agree with you and your patch Andreas, please commit.

06/11/09 17:11:31 changed by ahocevar

  • status changed from new to closed.
  • resolution set to fixed.

(In [1043]) Synchronize a layer record's title field with its layer's name. r=elemoine (closes #85)

06/11/09 20:06:33 changed by tschaub

(In [1044]) Layer title is stored in two places. We need to set the title in both places. After records have been added to the store, the store will keep these synchronized (see #85).