Ticket #83 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

ZoomSlider should start with Slider defaults

Reported by: tschaub Assigned to:
Priority: major Milestone: 0.5
Component: GeoExt.ZoomSlider Version: SVN
Keywords: Cc:
State: Commit

Description

The ZoomSlider prototype sets minValue and maxValue to null. If the slider is rendered before the map triggers zoomend, the slider value will be null. In the afterRender sequence, this results in setting the thumb style bottom to "NaNpx". Firefox doesn't complain about this. IE does.

The solution is to leave the minValue and maxValue defaults from Slider. Then, if the slider is bound to a map, they will be reset on zoomend.

Attachments

83.patch (0.6 kB) - added by tschaub on 06/09/09 02:35:41.
use minValue and maxValue defaults from Slider prototype

Change History

06/09/09 02:35:41 changed by tschaub

  • attachment 83.patch added.

use minValue and maxValue defaults from Slider prototype

06/09/09 02:36:50 changed by tschaub

  • owner changed.
  • type changed from enhancement to defect.
  • state changed from None to Review.
  • component changed from widgets to widgets.ZoomSlider.

Apologies for not having a simple example to demonstrate this problem. The GeoExplorer application breaks in IE without this change and works with it. All tests still pass.

06/09/09 11:25:16 changed by ahocevar

  • state changed from Review to Commit.

I can confirm the issue and that the patch fixes it. It does the right thing, since minValue and maxValue are indeed defined in Ext.Slider.

Thanks Tim for resolving this. Please commit.

06/09/09 11:37:16 changed by ahocevar

(In [1025]) using minValue and maxValue from Ext.Slider (see #83)

06/09/09 17:46:01 changed by tschaub

  • status changed from new to closed.
  • resolution set to fixed.

(In [1027]) Removing null value properties from the ZoomSlider prototype. These keep sensible defaults from being applied by Slider. If the slider is bound to a map, zoom related min/max values are set on zoomend. r=ahocevar (closes #83)