Ticket #80 (closed enhancement: fixed)

Opened 10 months ago

Last modified 10 months ago

mouse events should be stopped by popup when anchored

Reported by: tschaub Assigned to:
Priority: major Milestone: 0.5
Component: GeoExt.Popup Version:
Keywords: Cc:
State: Commit

Description

Open the popup.html example. Open a popup. Double-click on the popup. Try to select text in the popup. These events should not pass through to the map. When the popup is unanchored, things work.

Attachments

geoext-80.patch (12.2 kB) - added by ahocevar on 06/05/09 21:38:21.
make popup more behave like a real Ext.Window

Change History

06/05/09 15:07:35 changed by ahocevar

  • owner changed from sbenthall to ahocevar.

I am working on it right now.

06/05/09 21:38:21 changed by ahocevar

  • attachment geoext-80.patch added.

make popup more behave like a real Ext.Window

06/05/09 21:54:38 changed by ahocevar

  • owner deleted.
  • state changed from None to Review.

The attached patch makes some changes to the Popup to be closer to Ext.Window. The reported issue has to do with the fact that windows are not supposed to be added to a parent container.

To show this at the api levels, popups are no longer added to the map using map.add(popup), but instead using popup.show().

Also, popups are not restricted to the map viewport any more. They float now overlapping the viewport borders, and are hidden when the feature/lonlat the popup is for moves out of the viewport.

Tests and example were modified to work with the new api. Tests pass in FF3 and IE7. Thanks for any review.

06/05/09 21:55:30 changed by ahocevar

The above patch would not just close this ticket, but also #8.

06/05/09 22:16:40 changed by tschaub

  • state changed from Review to Commit.

Looks great Andreas. Thanks for this (and for closing #8). Please commit.

06/05/09 22:23:38 changed by ahocevar

  • status changed from new to closed.
  • resolution set to fixed.

(In [1000]) make popup behave like an Ext.Window, i.e. show it using popup.show() instead of adding it as item to the map panel. r=tschaub (closes #80) (closes #8)