Ticket #72 (closed enhancement: fixed)

Opened 1 year ago

Last modified 1 year ago

MapPanel should destroy any map it creates

Reported by: tschaub Assigned to: elemoine
Priority: major Milestone: 0.5
Component: GeoExt.MapPanel Version:
Keywords: Cc:
State: Commit

Description

Where we create a map, we should destroy it. In the case of the MapPanel, this is best done in beforeDestroy - before Ext has done any real destroy work.

Attachments

destroy.patch (2.8 kB) - added by tschaub on 05/22/09 23:30:20.
destroy what you create

Change History

05/22/09 23:30:20 changed by tschaub

  • attachment destroy.patch added.

destroy what you create

05/22/09 23:35:47 changed by tschaub

  • state changed from None to Review.

Tests pass in IE6, IE7, IE8, and FF3. Thanks for any review.

05/23/09 01:55:12 changed by ahocevar

  • state changed from Review to Commit.

Good catch Tim. This is the right way to destroy Ext components that contain an OL map. Please commit.

05/23/09 08:21:00 changed by tschaub

  • status changed from new to closed.
  • resolution set to fixed.

(In [862]) In cases where a MapPanel creates a map, it should also destroy the map. r=ahocevar (closes #72)