Opened 8 years ago

Closed 8 years ago

#64 closed defect (invalid)

popup and mappanel tests fail in IE7

Reported by: bartvde Owned by: elemoine
Priority: major Milestone: 0.5
Component: GeoExt.MapPanel Version:
Keywords: Cc:
State: Review

Description

invalid argument error in PanZoom.js of OpenLayers (so maybe this deserves a ticket there as well, needs further investigation):

    _removeButton: function(btn) {
        OpenLayers.Event.stopObservingElement(btn);
        btn.map = null;
    ****    this.div.removeChild(btn);
        OpenLayers.Util.removeItem(this.buttons, btn);
    },

line marked wtih

Attachments (1)

ticket64.patch (571 bytes) - added by bartvde 8 years ago.
patch fixing the issue

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by bartvde

Hmmm not sure why this is happening, if I comment out this one the next failure is in Map.js:

this.layerContainerDiv.removeChild(layer.div);

So is this test case valid?

This line causes the failures in Popup.html testcase:

context.mapPanel.destroy();

comment:2 follow-up: Changed 8 years ago by bartvde

It also happens in the MapPanel.html testcases.

comment:3 in reply to: ↑ 2 Changed 8 years ago by bartvde

Replying to bartvde:

It also happens in the MapPanel.html testcases.

But not for panel.destroy() lines, only the ones for which the map panel has been defined with a renderTo property.

comment:4 Changed 8 years ago by bartvde

  • Summary changed from popup tests fail in IE7 to popup and mappanel tests fail in IE7

comment:5 Changed 8 years ago by bartvde

Is this not because both ExtJS and OpenLayers are trying to destroy the same div?

Changed 8 years ago by bartvde

patch fixing the issue

comment:6 Changed 8 years ago by bartvde

  • State changed from None to Review

Please review.

comment:7 Changed 8 years ago by bartvde

  • Component changed from widgets.Popup to widgets.MapPanel
  • Owner changed from sbenthall to elemoine

comment:8 Changed 8 years ago by bartvde

On second thought I think this patch will cause unwanted memory leaks. Maybe the real fix is in OL?

comment:9 Changed 8 years ago by tschaub

  • Resolution set to invalid
  • Status changed from new to closed

All tests are passing in IE7 at r848 (OpenLayers revision 9407).

The PanPanel was exposing some trouble in Events.js. Perhaps you were seeing a consequence of this. See OL r9401 for the fix.

Note: See TracTickets for help on using tickets.