Ticket #62 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

ScaleStore does this.map.register instead of this.map.events.register

Reported by: elemoine Assigned to:
Priority: blocker Milestone: 0.5
Component: GeoExt.data Version:
Keywords: Cc:
State: Commit

Description

http://www.geoext.org/trac/geoext/browser/core/trunk/geoext/lib/GeoExt/data/ScaleStore.js#L62

Patch will follow.

Attachments

patch-62-r711-A0.diff (3.1 kB) - added by elemoine on 05/13/09 10:21:21.

Change History

05/12/09 17:06:44 changed by elemoine

  • type changed from enhancement to defect.

05/13/09 10:21:21 changed by elemoine

  • attachment patch-62-r711-A0.diff added.

05/13/09 10:21:53 changed by elemoine

  • state changed from None to Review.

05/13/09 10:25:11 changed by elemoine

The issue is worse, a "layeradded" listener is registered, while this event type does not exist in OpenLayers.Map ("addlayer" does). patch-62-r711-A0.diff provides a fix, and unit tests. Thanks for any review.

05/13/09 14:04:21 changed by fredj

  • state changed from Review to Commit.

looks good, thanks for the patch

05/13/09 15:56:19 changed by elemoine

  • status changed from new to closed.
  • resolution set to fixed.

(In [719]) ScaleStore does this.map.register instead of this.map.events.register, r=fredj (closes #62)

(follow-up: ↓ 7 ) 05/13/09 16:13:43 changed by bartvde

Hi Eric, a question, should we not be listening to the layerstore instead of using the map directly? Or what is GeoExt's policy in this regard?

(in reply to: ↑ 6 ) 05/13/09 16:52:26 changed by tschaub

Replying to bartvde:

Hi Eric, a question, should we not be listening to the layerstore instead of using the map directly? Or what is GeoExt's policy in this regard?

Since the ScaleStore is configured with a map, it makes sense to listen to map events. There is no LayerStore in this case.