Opened 6 years ago

Closed 6 years ago

#453 closed enhancement (fixed)

FeatureEditorGrid enhancements

Reported by: pgiraud Owned by:
Priority: major Milestone: ux
Component: ux Version:
Keywords: Cc:
State: Commit


Here are some (mostly cosmetic and usability oriented) enhancements for the FeatureEditorGrid UX:

  • save and delete buttons are disabled when they're not needed,
  • iconCls is removed because it's not really required in my opinion. It avoids weird display when no corresponding style is given (see current example),
  • buttons location and order is changed to separate them a bit (priority and functionality),
  • clickToEdit is set to 1 (as in Ext::PropertyGrid), to avoid too much clicks.

In the example, the save button (which is the important one) is given more visual focus as well (location and styling) in order to give it the priority.

Attachments (1)

patch-453-A0.diff (7.2 KB) - added by pgiraud 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by pgiraud

Updated patch to add the following :

  • hiding column headers and better view config (example),
  • clicking on the line shows the corresponding editor.

comment:2 Changed 6 years ago by ahocevar

@pgiraud, looking at our UX rules, you can commit any time, since you're one of the module maintainers - unless you have a different deal with Eric.

comment:3 Changed 6 years ago by elemoine

  • State changed from None to Commit


comment:4 Changed 6 years ago by elemoine

  • Component changed from GeoExt to ux
  • Milestone changed from 1.2 to ux
  • Version 1.1 deleted

Changed 6 years ago by pgiraud

comment:5 Changed 6 years ago by pgiraud

Updated patch to add the following:

  • modifyControlOptions property.

comment:6 Changed 6 years ago by pgiraud

  • Resolution set to fixed
  • Status changed from new to closed

(In [2874]) Adding some enhancements to the feature editor grid mainly for usability. Closes #453

Note: See TracTickets for help on using tickets.