Opened 6 years ago

Closed 6 years ago

#432 closed defect (fixed)

getAbsoluteUrl fails in IE9

Reported by: bartvde Owned by:
Priority: major Milestone: 1.1
Component: GeoExt.data.PrintProvider Version: 1.0
Keywords: Cc:
State: Commit

Attachments (1)

geoext-432.patch (520 bytes) - added by bartvde 6 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by bartvde

  • Resolution set to fixed
  • Status changed from new to closed

(In [2741]) switch to Ext 3.4.0, we needs this to fix #432

comment:2 Changed 6 years ago by bartvde

  • Resolution fixed deleted
  • Status changed from closed to reopened

That commit message should not have closed this ticket, the closes hook is getting too smart for me :-)

Changed 6 years ago by bartvde

comment:3 Changed 6 years ago by bartvde

  • State changed from None to Review

Okay, the attached one-line patch fixes this, the test_getAbsoluteUrl tests are now passing again in IE9.

However there is one more failing test for PrintProvider in IE9 but that's out of scope of this ticket.

Please review.

comment:4 Changed 6 years ago by pgiraud

  • State changed from Review to Commit

This is perfect for me. I can confirm that this fixes the issue. Thanks a lot. Please commit.

comment:5 Changed 6 years ago by bartvde

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [2743]) getAbsoluteUrl fails in IE9, r=pgiraud (closes #432)

comment:6 Changed 6 years ago by ahocevar

  • Resolution fixed deleted
  • Status changed from closed to reopened

Why didn't you add Ext.isIE9 as well? And why do we work around this in GeoExt in the first place?

comment:7 Changed 6 years ago by ahocevar

I'd prefer if this was reverted, and we advise people to use ext 3.4.

comment:8 Changed 6 years ago by bartvde

@ahocevar, it could also read if (Ext.isIE && !Ext.isIE9) however, then when IE10 comes out we need to change code again, that's why I wrote the more elaborate (Ext.isIE6 && Ext.isIE7 && Ext.isIE8).

IE9 does not support creating markup from content (<a href="foo"></a>).

So even if you use Ext 3.4.0, the current code won't work.

comment:9 Changed 6 years ago by ahocevar

  • Resolution set to fixed
  • Status changed from reopened to closed

Oh, got it now. Is this independent of the doctype? Anyway, in this case Bart, please apologize the noise.

Note: See TracTickets for help on using tickets.