Opened 7 years ago

Closed 7 years ago

#426 closed enhancement (fixed)

WMSCapabilitiesReader should better deal with service exceptions

Reported by: bartvde Owned by:
Priority: major Milestone: 1.1
Component: GeoExt.data.WMSCapabilitiesReader Version: 1.0
Keywords: Cc:
State: Commit

Description

Now that we have better OGC service exception handling in OpenLayers, we should make use of it in the WMSCapabilitiesReader, returning success false in readRecords and returning the message as well.

Attachments (1)

geoext-426.patch (2.5 KB) - added by bartvde 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by bartvde

So the question now is, do we throw a Ext.data.DataReader.Error or do we return success false. AFAICT using success false there is no way to get the exception object across, so throwing an error might be the right way to go.

comment:2 Changed 7 years ago by bartvde

Alternatively we could also create our own Error object like the JsonReader does in Ext, however I think what we experience when getting a service exception matches well with "invalid-response"

Changed 7 years ago by bartvde

comment:3 Changed 7 years ago by bartvde

  • State changed from None to Review

Tests pass in Firefox 4 and Safari 5, TIA for any review.

comment:4 Changed 7 years ago by bartvde

Ofcourse, once we agree on the approach, a similar thing should be done for the WFSCapabilitiesReader

comment:5 Changed 7 years ago by tschaub

  • State changed from Review to Commit

Looks good. Later we may want to extract some detail to include in the error object. Please commit.

comment:6 Changed 7 years ago by bartvde

  • Resolution set to fixed
  • Status changed from new to closed

(In [2727]) WMSCapabilitiesReader should better deal with service exceptions, r=tschaub (closes #426)

Note: See TracTickets for help on using tickets.