Opened 7 years ago

Closed 7 years ago

#393 closed defect (fixed)

the SimplePrint tests fail

Reported by: elemoine Owned by:
Priority: major Milestone: ux
Component: ux Version:
Keywords: Cc:
State: Complete

Description

test_initComponent  fail 0 ok 5
exception: : object: target.ownerCt is undefined
in ( [object Object]) at [...]/PrintProviderField.js line 180

Patch to come.

Attachments (1)

patch-393-A0.diff (1.1 KB) - added by elemoine 7 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by elemoine

In the SimplePrint.html tests the SimplePrint component has no ownerCt (it has renderTo set). Because of that, and because SimplePrint doesn't set a PrintProvider in the PrintProviderField instances it creates, we get an error in PrintProviderField.onBeforeDestroy. Here:

var printProvider = this.printProvider || target.ownerCt.printProvider; 
printProvider.un("layoutchange", this.onProviderChange, this); 

The solution is to make SimplePrint set PrintProvider objects in the PrintProviderField plugins it creates.

Changed 7 years ago by elemoine

comment:2 Changed 7 years ago by elemoine

  • State changed from None to Review

comment:3 Changed 7 years ago by elemoine

  • Type changed from enhancement to defect

comment:4 Changed 7 years ago by ahocevar

  • State changed from Review to Commit

Looks good. Please commit.

comment:5 Changed 7 years ago by fredj

  • Resolution set to fixed
  • State changed from Commit to Complete
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.