Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#37 closed enhancement (fixed)

layer store should respect the order of layers in the map layers array

Reported by: tschaub Owned by:
Priority: critical Milestone: 0.5
Component: GeoExt.data.LayerStore Version:
Keywords: Cc:
State: Commit

Description


Attachments (2)

37.patch (7.4 KB) - added by tschaub 8 years ago.
sync layer order on store.insert and map.setLayerIndex
geoext-37.patch (7.5 KB) - added by ahocevar 8 years ago.
fixed test html (needs width and height css

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by tschaub

(In [340]) Listen for layer reordering on the map and update store. (see #37)

comment:2 Changed 8 years ago by tschaub

(In [341]) Correctly handle layer order on store.insert. (see #37)

comment:3 Changed 8 years ago by tschaub

  • State changed from None to Review

This depends on #36. Patch includes those changes as well (will update when #36 is closed).

Tests pass. Thanks for any review.

Changed 8 years ago by tschaub

sync layer order on store.insert and map.setLayerIndex

comment:4 Changed 8 years ago by tschaub

Updated patch applies to trunk at r346.

Changed 8 years ago by ahocevar

fixed test html (needs width and height css

comment:5 Changed 8 years ago by ahocevar

  • State changed from Review to Commit

I uploaded a new patch which fixes the test html (requires size to be set, otherwise map.getSize() will fail in IE). Please commit.

comment:6 Changed 8 years ago by tschaub

  • Resolution set to fixed
  • Status changed from new to closed

(In [356]) If bound to a map, the layer store will respect the order of layers on the map. Reordering map layers reorders records in the store. Inserting a record in the store places the layer in the appropriate order on the map. r=ahocevar (closes #37)

comment:7 Changed 8 years ago by tschaub

Thanks the reviews Andreas. And for fixing that issue in IE.

Note: See TracTickets for help on using tickets.