Ticket #37 (closed enhancement: fixed)

Opened 1 year ago

Last modified 1 year ago

layer store should respect the order of layers in the map layers array

Reported by: tschaub Assigned to:
Priority: critical Milestone: 0.5
Component: GeoExt.data.LayerStore Version:
Keywords: Cc:
State: Commit

Attachments

37.patch (7.4 kB) - added by tschaub on 04/03/09 18:12:54.
sync layer order on store.insert and map.setLayerIndex
geoext-37.patch (7.5 kB) - added by ahocevar on 04/07/09 19:47:19.
fixed test html (needs width and height css

Change History

04/03/09 00:57:37 changed by tschaub

(In [340]) Listen for layer reordering on the map and update store. (see #37)

04/03/09 01:18:58 changed by tschaub

(In [341]) Correctly handle layer order on store.insert. (see #37)

04/03/09 01:22:18 changed by tschaub

  • state changed from None to Review.

This depends on #36. Patch includes those changes as well (will update when #36 is closed).

Tests pass. Thanks for any review.

04/03/09 18:12:54 changed by tschaub

  • attachment 37.patch added.

sync layer order on store.insert and map.setLayerIndex

04/03/09 18:13:52 changed by tschaub

Updated patch applies to trunk at r346.

04/07/09 19:47:19 changed by ahocevar

  • attachment geoext-37.patch added.

fixed test html (needs width and height css

04/07/09 19:48:19 changed by ahocevar

  • state changed from Review to Commit.

I uploaded a new patch which fixes the test html (requires size to be set, otherwise map.getSize() will fail in IE). Please commit.

04/07/09 21:11:27 changed by tschaub

  • status changed from new to closed.
  • resolution set to fixed.

(In [356]) If bound to a map, the layer store will respect the order of layers on the map. Reordering map layers reorders records in the store. Inserting a record in the store places the layer in the appropriate order on the map. r=ahocevar (closes #37)

04/07/09 22:22:07 changed by tschaub

Thanks the reviews Andreas. And for fixing that issue in IE.