Opened 7 years ago

Closed 6 years ago

#368 closed enhancement (fixed)

print provider should send scale info

Reported by: bartvde Owned by:
Priority: major Milestone: 1.1
Component: GeoExt.data.PrintProvider Version: 1.0
Keywords: Cc:
State: Commit

Description

If an OpenLayers layer has a minscale of 50000 (and the underlying WMS does not have this scale restriction set), the print can end up different from the view in the webmapping application. So the print provider should send scale info (minScale, maxScale) to the print service, and the print service should use this info to determine whether or not a certain layer needs to be drawn.

Attachments (1)

geoext-368.patch (10.9 KB) - added by bartvde 7 years ago.

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by bartvde

comment:1 Changed 7 years ago by bartvde

  • State changed from None to Review

I've chosen to use the OGC concepts minScaleDenominator (which maps to OpenLayers maxScale) and maxScaleDenominator (which maps to OpenLayers minScale). PrintPage tests pass in IE8 and FF 3.6, please review.

comment:2 follow-up: Changed 7 years ago by ahocevar

Does this depend on a server side change in MapFish Print? I don't see it checking for min/maxScale at this point. If there is, can you please provide a link to the according MapFish ticket? Since MapFish Print is configured in a very similar way to OpenLayers layers, I'm not sure if using min/maxScaleDenominator is really that much better than minScale/maxScale.

comment:3 Changed 7 years ago by bartvde

Hi Andreas, see http://trac.mapfish.org/trac/mapfish/ticket/604

We'll be attaching a patch for that tomorrow after some more testing.

comment:4 in reply to: ↑ 2 Changed 7 years ago by bartvde

Replying to ahocevar:

Does this depend on a server side change in MapFish Print? I don't see it checking for min/maxScale at this point. If there is, can you please provide a link to the according MapFish ticket? Since MapFish Print is configured in a very similar way to OpenLayers layers, I'm not sure if using min/maxScaleDenominator is really that much better than minScale/maxScale.

Hi Andreas, do you mean mapping a property named minScale to the OpenLayers layer.options.minScale? I always found the OpenLayers names very confusing (since maxScale < minScale), that's why I changed the concept.

comment:5 Changed 7 years ago by ahocevar

@bartvde: yes, my impression is that almost all properties in the MapFish Print layer descriptions are the same as in OpenLayers. I'd say let's see how the MapFish developers decide, and wait with this patch until the server side patch is accepted there.

comment:6 Changed 6 years ago by bartvde

Okay, this was committed in MF print service, so I would be happy to get a review on this now. TIA.

comment:7 Changed 6 years ago by ahocevar

  • State changed from Review to Commit

Looks good Bart. Please commit.

comment:8 Changed 6 years ago by bartvde

  • Resolution set to fixed
  • Status changed from new to closed

(In [2749]) print provider should send scale info, r=ahocevar (closes #368)

Note: See TracTickets for help on using tickets.