Opened 9 years ago

Closed 9 years ago

#36 closed enhancement (fixed)

calling store.add for a LayerStore with a bound map adds records twice

Reported by: tschaub Owned by:
Priority: blocker Milestone: 0.5
Component: GeoExt.data.LayerStore Version:
Keywords: Cc:
State: Commit

Description

The onAdd and onLayerAdd methods both need to set and check the _adding and _removing properties.

Attachments (1)

36.patch (2.9 KB) - added by tschaub 9 years ago.
take care not to add twice

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by tschaub

take care not to add twice

comment:1 Changed 9 years ago by tschaub

  • Component changed from data to data.LayerStore
  • State changed from None to Review

Tests fail and pass after this patch. Thanks for the review.

comment:2 Changed 9 years ago by tschaub

(In [334]) Fixing the layer store add method (see #36).

comment:3 Changed 9 years ago by ahocevar

  • State changed from Review to Commit

Thanks Tim for spotting this. Patch looks good. Please commit.

comment:4 Changed 9 years ago by tschaub

  • Resolution set to fixed
  • Status changed from new to closed

(In [346]) Take care not to add records twice when calling store.add. r=ahocevar (closes #36)

Note: See TracTickets for help on using tickets.