Opened 7 years ago

Closed 7 years ago

#357 closed defect (fixed)

unbind function of ZoomSlider is not totally safe

Reported by: bartvde Owned by:
Priority: major Milestone: 1.1
Component: GeoExt.ZoomSlider Version: trunk
Keywords: Cc:
State: Commit

Description

The destroy method of the ZoomSlider calls unbind, where an event on the OpenLayers.Map is unregistered. However, there is no check for this.map.events

In IE we are running into destroy issues where this.map.events is already null when the ZoomSlider is being destroyed.

Attachments (2)

geoext-357.patch (484 bytes) - added by bartvde 7 years ago.
geoext-357.1.patch (1.0 KB) - added by fredj 7 years ago.
also check for map.events in LayerOpacitySlider (not tested)

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by bartvde

comment:1 Changed 7 years ago by bartvde

  • State changed from None to Review

Changed 7 years ago by fredj

also check for map.events in LayerOpacitySlider (not tested)

comment:2 Changed 7 years ago by fredj

  • State changed from Review to Commit

please commit if tests pass.

comment:3 Changed 7 years ago by bartvde

  • Resolution set to fixed
  • Status changed from new to closed

(In [2430]) the unbind functions of ZoomSlider and LayerOpacitySlider are not totally safe, r=fredj (closes #357)

Note: See TracTickets for help on using tickets.