Opened 8 years ago

Closed 8 years ago

#34 closed enhancement (fixed)

feature and layer records should clone on copy

Reported by: tschaub Owned by:
Priority: major Milestone: 0.5
Component: GeoExt.data Version:
Keywords: Cc:
State: Commit

Description

The FeatureRecord and LayerRecord prototypes need a custom copy so they clone their feature and layer values.

Attachments (1)

copy.patch (3.9 KB) - added by tschaub 8 years ago.
clone ol objects on record copy

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by tschaub

clone ol objects on record copy

comment:1 Changed 8 years ago by tschaub

  • State changed from None to Review

Tests pass in FF3.

comment:2 Changed 8 years ago by ahocevar

  • State changed from Review to Commit

This looks good. And I always admire the beauty of tschaub's unit tests. Not just in GeoExt, but also in OpenLayers. Please commit.

comment:3 Changed 8 years ago by tschaub

  • Resolution set to fixed
  • Status changed from new to closed

(In [357]) Records that contain references to OL objects should clone those objects on copy. Done here for the FeatureRecord and LayerRecord. r=ahocevar (closes #34)

Note: See TracTickets for help on using tickets.