Opened 7 years ago

Last modified 6 years ago

#317 new enhancement

WMSCapabilitiesLoader should have a filter

Reported by: ahocevar Owned by:
Priority: minor Milestone: 1.2
Component: GeoExt.tree.WMSCapabilitiesLoader Version: trunk
Keywords: api change Cc:
State: None

Description

rather than checking whether the createNode method returns a node. Because it seems that the Ext API does not know the case where createNode does not return a node.

Change History (4)

comment:1 Changed 7 years ago by ahocevar

  • Keywords api change added
  • Priority changed from minor to blocker

comment:2 Changed 7 years ago by tschaub

I don't get why this implies a backwards incompatible API change. I think you are talking about adding a filter property to the WMSCapabilitiesLoader. This would presumably be used in the private processLayer method. What about this change would be backwards incompatible? It sounds like a bug fix or an enhancement to me (and either could come with 1.1).

Please add detail about the API breaking nature of this change.

comment:3 Changed 7 years ago by ahocevar

  • Milestone changed from 1.0 to 1.1
  • Priority changed from blocker to minor

The createNode method is public (see Ext.tree.TreeLoader) - it is the method to override when you want to customize the way the nodes are generated. Right now, people can prevent nodes from being added to the WMSCapabilities tree by having the createNode method return falsish. But Ext.tree.TreeLoader::createNode is not supposed to return anything different from a node.

But since this behavior of checking the result of createNode is not advertised anywhere (except in a users list reply of mine), I guess it is safe to move this to 1.1.

comment:4 Changed 6 years ago by ahocevar

  • Milestone changed from 1.1 to 1.2

Batch move of tickets to finish the 1.1 milestone.

Note: See TracTickets for help on using tickets.