Opened 7 years ago

Closed 7 years ago

#310 closed enhancement (fixed)

PrintPreview should create its own scales store

Reported by: tschaub Owned by:
Priority: major Milestone: ux
Component: ux Version: trunk
Keywords: Cc:
State: Commit

Description

The PrintPreview component should work with a limited set of scales instead of all the scales advertised by the print provider. The PrintMapPanel calculates a subset of resolutions based on the advertised scales. The PrintPreview component should use the scales that correspond to the PrintMapPanel's print resolutions.

Attachments (4)

310.patch (2.1 KB) - added by tschaub 7 years ago.
use a subset of the advertised scales
geoext-310.patch (2.5 KB) - added by ahocevar 7 years ago.
geoext-310.2.patch (3.8 KB) - added by ahocevar 7 years ago.
update to fit latest patch for #309
geoext-310.3.patch (4.5 KB) - added by ahocevar 7 years ago.
inherit autoWidth and autoHeight

Download all attachments as: .zip

Change History (11)

Changed 7 years ago by tschaub

use a subset of the advertised scales

comment:1 Changed 7 years ago by tschaub

  • State changed from None to Review

This depends on the patch for #309.

Changed 7 years ago by ahocevar

comment:2 Changed 7 years ago by ahocevar

Now that this extra scales store is part of the latest patch for #309, an improved PrintPreview could look like in attachment:geoext-310.patch.

The noticeable change is that the preview has no ZoomPanel, ZoomBox and DragPan any more, so scales have to be selected from the scales combo box, which only contains scales that are in the range of the source map.

Changed 7 years ago by ahocevar

update to fit latest patch for #309

comment:3 Changed 7 years ago by tschaub

With this patch, the print preview dialog in our application is not properly sized (it's about 10 pixels wide). Could be a css issue, I'll check into it.

comment:4 Changed 7 years ago by tschaub

Looks like this happens in applications that don't specify a width for the PrintMapPanel. When I do specify a width, the map is not entirely displayed in the PrintPreview.

Changed 7 years ago by ahocevar

inherit autoWidth and autoHeight

comment:5 Changed 7 years ago by ahocevar

The container that wraps the form and the PrintMapPanel needs to inherit the PrintPreview's autoHeight and autoWidth settings, otherwise sizing will fail if no width or height is configured for the PrintMapPanel. attachment:geoext-310.3.patch addresses this issue, and makes use of the latest improvements from #309.

comment:6 Changed 7 years ago by tschaub

  • State changed from Review to Commit

comment:7 Changed 7 years ago by ahocevar

  • Resolution set to fixed
  • Status changed from new to closed

(In [2269]) Use the PrintMapPanel's previewScales store and the limitScales option. Don't let the user zoom in the preview by other means than choosing a print scale from the scales combo. r=tschaub (closes #310)

Note: See TracTickets for help on using tickets.