Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#299 closed enhancement (invalid)

have an option to have legend items visible irregardless of layer visibility

Reported by: bartvde Owned by: bartvde
Priority: major Milestone: 1.0
Component: GeoExt.LegendPanel Version: trunk
Keywords: Cc:
State: Complete

Description

We have a requirement that legend items need to be visible irregardless of layer visibility. It would be nice if GeoExt LegendPanel had an option for this.

Attachments (4)

ticket299.2.patch (2.2 KB) - added by bartvde 7 years ago.
patch no tests as yet
ticket299.patch (2.2 KB) - added by bartvde 7 years ago.
patch no tests as yet
geoext-299.patch (3.4 KB) - added by bartvde 7 years ago.
better patch, now also includes testcases
geoext-299.2.patch (1.4 KB) - added by ahocevar 7 years ago.
no need to change code here - we have the beforehide listener to accomplish this

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by bartvde

patch no tests as yet

comment:1 Changed 7 years ago by bartvde

  • Owner set to bartvde
  • Status changed from new to assigned

Changed 7 years ago by bartvde

better patch, now also includes testcases

comment:2 Changed 7 years ago by bartvde

  • State changed from None to Review

Tests pass in FF 3.6, please review. TIA.

comment:3 Changed 7 years ago by ahocevar

Bart: Ext gives us everything we need to accomplish this. See the test in attachment:geoext-299.2.patch.

var legend = new GeoExt.LegendPanel({
    defaults: {
        listeners: {
            beforehide: function() { return false; }
        }
    }
});

If you agree, you can commit this patch (just to show that it's possible in the test) and mark the ticket invalid.

Changed 7 years ago by ahocevar

no need to change code here - we have the beforehide listener to accomplish this

comment:4 Changed 7 years ago by bartvde

Excellent suggestion Andreas! Thanks. I'll commit the test and close the ticket as invalid.

comment:5 Changed 7 years ago by bartvde

(In [2360]) add testcase to show how legend panel visibility can be independent of layer visibility, by using the beforehide event, thanks to ahocevar, see #299

comment:6 Changed 7 years ago by bartvde

  • Resolution set to invalid
  • Status changed from assigned to closed

See r2360 for the added testcase.

comment:7 Changed 7 years ago by bartvde

  • State changed from Review to Complete
Note: See TracTickets for help on using tickets.