Opened 7 years ago

Closed 7 years ago

#288 closed enhancement (fixed)

FeatureBrowser ux

Reported by: pgiraud Owned by:
Priority: minor Milestone: ux
Component: ux Version:
Keywords: Cc:
State: Commit

Attachments (3)

patch-featurebrowser.diff (16.3 KB) - added by pgiraud 7 years ago.
patch-featurebrowser.1.diff (15.9 KB) - added by elemoine 7 years ago.
updated patch, with [2220] from fredj and possibly other commits from pgiraud
patch-featurebrowser.2.diff (18.1 KB) - added by elemoine 7 years ago.
new patch with the skippedFeatureAttributes option (from [2221])

Download all attachments as: .zip

Change History (14)

Changed 7 years ago by pgiraud

comment:1 Changed 7 years ago by elemoine

It looks good to me. But I'm a bit biased. So I'd appreciate if someone else could also review it.

Pierre, I created http://trac.geoext.org/wiki/ux/FeatureBrowser for you. I hope the description is ok to you.

comment:2 Changed 7 years ago by elemoine

  • Milestone changed from 1.0 to ux
  • Version trunk deleted

comment:3 Changed 7 years ago by ahocevar

Without a closer look a the code, and this is maybe a stupid question: What happened to the FeatureView that Eric was talking about in http://www.geoext.org/pipermail/dev/2010-May/000745.html ?

comment:4 Changed 7 years ago by pgiraud

See my answer in the same thread. Don't hesitate to ask if this is not clear enough. http://www.geoext.org/pipermail/dev/2010-May/000754.html

comment:5 follow-up: Changed 7 years ago by fredj

the FeatureBrowser takes an array of features as argument; would it be possible to use a FeatureStore instead ?

comment:6 in reply to: ↑ 5 ; follow-up: Changed 7 years ago by ahocevar

Replying to fredj:

the FeatureBrowser takes an array of features as argument; would it be possible to use a FeatureStore instead ?

I think the most common use for the FeatureBrowser is in a getfeatureinfo handler of OpenLayers.Control.GetFeatureInfo, and this returns an array of features. So I don't see anything wrong in configuring it with an array of features.

comment:7 in reply to: ↑ 6 Changed 7 years ago by fredj

Replying to ahocevar:

Replying to fredj:

the FeatureBrowser takes an array of features as argument; would it be possible to use a FeatureStore instead ?

I think the most common use for the FeatureBrowser is in a getfeatureinfo handler of OpenLayers.Control.GetFeatureInfo, and this returns an array of features. So I don't see anything wrong in configuring it with an array of features.

You're right, I forget the main use case ...

comment:8 Changed 7 years ago by fredj

In featurebrowser.html, ext v3.1.1 is used; switch to the lastest stable (v3.2.1) ?

comment:9 Changed 7 years ago by fredj

(In [2220]) coding style, don't use local var for bbar and items (see #288)

Changed 7 years ago by elemoine

updated patch, with [2220] from fredj and possibly other commits from pgiraud

Changed 7 years ago by elemoine

new patch with the skippedFeatureAttributes option (from [2221])

comment:10 Changed 7 years ago by fredj

  • State changed from Review to Commit

Ready to commit.

BTW, I've made some minor update into the sandbox (r2289).

comment:11 Changed 7 years ago by fredj

  • Resolution set to fixed
  • Status changed from new to closed

(In [2293]) Add the FeatureBrowser ux (http://trac.geoext.org/wiki/ux/FeatureBrowser). p=pgiraud, r=elemoine,ahocevar,fredj (closes #288)

Note: See TracTickets for help on using tickets.