Opened 8 years ago

Closed 8 years ago

#276 closed enhancement (fixed)

examples: do not use custom build of ExtJS

Reported by: bartvde Owned by:
Priority: major Milestone: 0.7
Component: examples Version: 0.7 RC2
Keywords: Cc:
State: Pullup

Description

I would rather see our examples use:

http://extjs.cachefly.net/ext-2.2.1/adapter/ext/ext-base.js
http://extjs.cachefly.net/ext-2.2.1/ext-all.js

Instead of:

http://extjs.cachefly.net/builds/ext-cdn-771.js

There is now no uniformity in the GeoExt examples, a mixture of the above is found. I'll attach a patch to make things uniform.

Attachments (1)

276.patch (14.4 KB) - added by bartvde 8 years ago.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by bartvde

comment:1 Changed 8 years ago by bartvde

  • State changed from None to Review

comment:2 Changed 8 years ago by elemoine

A one time we decided to use extjs.cachefly.net, but I don't know why. Bart why don't you want our examples to rely on cachefly?

comment:3 Changed 8 years ago by bartvde

I don't really care which one we choose, I really care about the unformity, though I have a preference for the first option since:

1) it is easy to see which version is used 2) it is easy to see which adapter was used

For instance if somebody reports a problem with the jQuery adapter, it would be easier to track down.

It is also easier to use the debug version in this case, just add -debug to the url.

comment:4 Changed 8 years ago by bartvde

Btw Eric, our examples still depend on cachefly in my preferred situation, just not on the custom builds.

comment:5 Changed 8 years ago by ahocevar

  • State changed from Review to Commit

I'm in favor of using full builds (hosted on cachefly) in the examples. It will make them load slower, but it will save us from questions on the users list why Ext JS feature xy does not work, just having to tell them that it is not included in the build for the example that they extended to build their application.

Please commit if elemoine agrees.

comment:6 Changed 8 years ago by elemoine

  • Version changed from trunk to 0.7 RC2

sorry guys I missed that Bart was just suggesting to not use the custom build and still rely on cachefly. Bart you can commit this and set the ticket's state to Pullup once done.

comment:7 Changed 8 years ago by bartvde

  • State changed from Commit to Pullup

see r2157

comment:8 Changed 8 years ago by elemoine

  • Resolution set to fixed
  • Status changed from new to closed

(In [2165]) pull up patch for ticket 276 (closes #276)

Note: See TracTickets for help on using tickets.