Ticket #265 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Move onStoreUpdate from LegendPanel to LayerLegend

Reported by: ahocevar Assigned to:
Priority: major Milestone: 0.7
Component: GeoExt.LegendPanel Version: 0.7 RC1
Keywords: Cc:
State: Pullup

Description

Currently, legends can only be updated when they are part of a LegendPanel, because the LegendPanel handles the store's update event.

The attached patch moves that handler to LayerLegend, and from now on a stand-alone Legend will also be updated when the LayerRecord changes.

All relevant tests still pass. Please review.

Attachments

geoext-265.patch (8.2 kB) - added by ahocevar on 04/19/10 23:22:38.

Change History

04/19/10 23:22:38 changed by ahocevar

  • attachment geoext-265.patch added.

04/20/10 06:27:06 changed by tschaub

  • state changed from Review to Commit.

Looks good Andreas. Please commit. My review also brought up #266 - not directly related, but another update issue.

04/20/10 12:54:12 changed by ahocevar

  • status changed from new to closed.
  • resolution set to fixed.

(In [2099]) moved onStoreUpdate from LegendPanel to LayerLegend. r=tschaub (closes #265)

(follow-up: ↓ 4 ) 04/20/10 20:59:56 changed by tschaub

  • status changed from closed to reopened.
  • state changed from Commit to Pullup.
  • resolution deleted.

If the release manager approves, we should pull this up to the 0.7 branch, right?

(in reply to: ↑ 3 ) 04/26/10 14:35:12 changed by elemoine

Replying to tschaub:

If the release manager approves, we should pull this up to the 0.7 branch, right?

Looks good to me. Thanks,

04/27/10 09:14:15 changed by elemoine

  • version changed from trunk to 0.7 RC1.

04/27/10 09:31:30 changed by elemoine

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [2121]) pull up patch for ticket 265 (closes #265)