Opened 7 years ago

Closed 7 years ago

#256 closed enhancement (fixed)

feature editing ux

Reported by: elemoine Owned by:
Priority: major Milestone: ux
Component: ux Version:
Keywords: Cc:
State: Commit

Description

an ux for editing features

Attachments (7)

patch-256-A0.diff (19.0 KB) - added by elemoine 7 years ago.
patch-256-A1.diff (23.1 KB) - added by elemoine 7 years ago.
patch-256-A2.diff (19.3 KB) - added by pgiraud 7 years ago.
patch-256-A3.diff (21.7 KB) - added by elemoine 7 years ago.
patch-256-A4.diff (38.6 KB) - added by elemoine 7 years ago.
patch-256-A5.diff (39.1 KB) - added by pgiraud 7 years ago.
patch-256-A6.diff (40.0 KB) - added by elemoine 7 years ago.

Download all attachments as: .zip

Change History (12)

Changed 7 years ago by elemoine

Changed 7 years ago by elemoine

Changed 7 years ago by pgiraud

Changed 7 years ago by elemoine

comment:1 Changed 7 years ago by elemoine

Depends on #261 and #274.

comment:2 Changed 7 years ago by elemoine

Tests pass in FF3, IE7, and Chromium 5. Example works in FF3 and IE7. I still have an issue with Chromium: features don't display on the map.

Changed 7 years ago by elemoine

Changed 7 years ago by pgiraud

comment:3 Changed 7 years ago by pgiraud

  • State changed from None to Review

My last patch fixes some typos or missings in the documentation. It also uses a combobox for the symbol attribute selection. I know think that this is ready for review.

Changed 7 years ago by elemoine

comment:4 Changed 7 years ago by elemoine

  • State changed from Review to Commit

patch-256-A6.diff just adds the possibility to pass extra event properties when calling cancelHandler, deleteHandler and saveHandler. It also corrects a typo that you had in the tests (search "gnsrid" in your patch).

Please commit if you agree with these changes.

comment:5 Changed 7 years ago by pgiraud

  • Resolution set to fixed
  • Status changed from new to closed

Fixed with r2183.

Note: See TracTickets for help on using tickets.