Opened 9 years ago

Closed 9 years ago

#25 closed enhancement (fixed)

add LayerReader

Reported by: elemoine Owned by:
Priority: major Milestone: 0.5
Component: GeoExt.data Version:
Keywords: Cc:
State: Commit

Description

The current LayerRecord constructor creates a layer record from an OpenLayers.Layer object. I think that (a) it should only be a specialized Record (with "layer" and "title" fields), and (b) we should have a LayerReader for actually converting layers into layer records.

Patch to come.

Attachments (2)

patch-25-r242-A0.diff (12.7 KB) - added by elemoine 9 years ago.
patch-25-r252-A1.diff (15.9 KB) - added by elemoine 9 years ago.

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by elemoine

Changed 9 years ago by elemoine

comment:1 Changed 9 years ago by elemoine

  • Component changed from MapPanel to data

patch-25-r252-A1.diff includes tests. Please review.

comment:2 Changed 9 years ago by ahocevar

  • State changed from Review to Commit

Great work elemoine! This is the right way to enforce the structure of layer records. If you can confirm that tests pass, please commit!

comment:3 Changed 9 years ago by ahocevar

(and once committed, please mark #27 as fixed too)

comment:4 Changed 9 years ago by elemoine

All tests pass.

comment:5 Changed 9 years ago by elemoine

  • Resolution set to fixed
  • Status changed from new to closed

(In [260]) add LayerReader, r=ahocevar (closes #25, #27)

Note: See TracTickets for help on using tickets.