Ticket #25 (closed enhancement: fixed)

Opened 1 year ago

Last modified 1 year ago

add LayerReader

Reported by: elemoine Assigned to:
Priority: major Milestone: 0.5
Component: GeoExt.data Version:
Keywords: Cc:
State: Commit

Description

The current LayerRecord constructor creates a layer record from an OpenLayers.Layer object. I think that (a) it should only be a specialized Record (with "layer" and "title" fields), and (b) we should have a LayerReader for actually converting layers into layer records.

Patch to come.

Attachments

patch-25-r242-A0.diff (12.7 kB) - added by elemoine on 03/22/09 18:49:44.
patch-25-r252-A1.diff (15.9 kB) - added by elemoine on 03/23/09 22:02:54.

Change History

03/22/09 18:49:44 changed by elemoine

  • attachment patch-25-r242-A0.diff added.

03/23/09 22:02:54 changed by elemoine

  • attachment patch-25-r252-A1.diff added.

03/23/09 22:03:39 changed by elemoine

  • owner changed.
  • component changed from MapPanel to data.

patch-25-r252-A1.diff includes tests. Please review.

03/24/09 08:50:56 changed by ahocevar

  • state changed from Review to Commit.

Great work elemoine! This is the right way to enforce the structure of layer records. If you can confirm that tests pass, please commit!

03/24/09 08:51:26 changed by ahocevar

(and once committed, please mark #27 as fixed too)

03/24/09 09:16:35 changed by elemoine

All tests pass.

03/24/09 09:17:27 changed by elemoine

  • status changed from new to closed.
  • resolution set to fixed.

(In [260]) add LayerReader, r=ahocevar (closes #25, #27)