Ticket #236 (closed task: fixed)

Opened 5 months ago

Last modified 5 months ago

GeoExt.ux Measure

Reported by: fvanderbiest Assigned to:
Priority: major Milestone:
Component: ux Version: trunk
Keywords: Cc:
State: Complete

Description

Here's a new ux: http://trac.geoext.org/wiki/ux/Measure

It creates ready-to-use actions for position, length and area measurements, by the way of an OpenLayers.Control.Measure.

Still needs unit tests.

Attachments

patch-236-A0.diff (25.4 kB) - added by elemoine on 03/09/10 22:16:04.
patch-236-A1.diff (20.2 kB) - added by elemoine on 03/10/10 13:34:01.
MeasurePosition removed

Change History

03/09/10 22:15:09 changed by elemoine

  • milestone deleted.

03/09/10 22:16:04 changed by elemoine

  • attachment patch-236-A0.diff added.

03/09/10 22:22:04 changed by elemoine

François, thanks for measure ux and the good code you've written. I took the code from your sandbox, made a few minor changes, wrote unit tests, and created a patch against geoext.ux. See patch-236-A0.diff, and tell me what you think. Also, I don't like that the user need to move the mouse to get the result tip, have you researched other options? Once this issue is resolved and I think this is good to go.

03/10/10 11:48:55 changed by fvanderbiest

Eric, there seems to be some problems with the patch, or this version of trac, since filenames are replaced by /dev/null in the viewer.

Regarding the fact that the user needs to move the mouse to display the tip, the only solution I could think of, is to display the tip at the corner of the geometry's bounding box. But I'm not sure this would be OK.

Also, regarding the child classes, I would add some api:config documentation for options iconCls, tooltip and template, at least to mention their default values.

Otherwise, the code looks good to me.

03/10/10 11:49:31 changed by fvanderbiest

BTW, thanks for the unit testing :-)

03/10/10 13:34:01 changed by elemoine

  • attachment patch-236-A1.diff added.

MeasurePosition removed

03/10/10 13:37:19 changed by elemoine

  • state changed from Needs more work to Commit.

patch-236-A1.diff removes MeasurePosition, as this is still unclear whether it makes to use OpenLayers.Control.Measure for "measuring positions". It's good to be committed. Thanks again fvanderbiest for this.

03/16/10 14:29:02 changed by fredj

  • status changed from new to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

closed by r1945