Opened 7 years ago

Closed 7 years ago

#228 closed enhancement (fixed)

need mechanism to add custom parameters for encoding of layers

Reported by: bartvde Owned by:
Priority: major Milestone: 0.7
Component: GeoExt.data.PrintProvider Version: trunk
Keywords: Cc:
State: Commit

Description

Andreas suggested using an event. MapFish used overrides for this.

Attachments (2)

ticket228.patch (8.9 KB) - added by bartvde 7 years ago.
geoext-228.patch (9.4 KB) - added by ahocevar 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by bartvde

comment:1 Changed 7 years ago by bartvde

  • State changed from None to Needs Discussion

Andreas, is this what you meant or you had something else in mind?

comment:2 Changed 7 years ago by ahocevar

@Bart: this is close to what I had in mind. But I wanted to give access to the whole encoded layer object, not just its custom params. New patch to come.

comment:3 Changed 7 years ago by ahocevar

  • State changed from Needs Discussion to Review

Tests pass in FF3.5. Please review.

Changed 7 years ago by ahocevar

comment:4 Changed 7 years ago by bartvde

  • State changed from Review to Commit

Thanks Andreas, looks good except for one obsolete line:

var customParams = {}; 

which can be removed now.

Please commit.

comment:5 Changed 7 years ago by ahocevar

  • Resolution set to fixed
  • Status changed from new to closed

(In [1909]) added beforeencodelayer and encodelayer events to PrintProvider. Thanks bartvde for the initial patch. r=bartvde,me (closes #228)

Note: See TracTickets for help on using tickets.