Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#213 closed enhancement (fixed)

geoext.ux.SimplePrint: print preview with print extent on the map and a form to set parameters

Reported by: ahocevar Owned by:
Priority: major Milestone: ux
Component: ux Version: trunk
Keywords: Cc:
State: Commit

Description (last modified by ahocevar)

Using GeoExt.PrintExtent and form plugins, this dialog provides everything for a simple print preview with mouse and form interaction. This ux depends on #204 and #210.

Attachments (3)

geoext-213.patch (24.3 KB) - added by ahocevar 8 years ago.
geoext-213-1.patch (23.5 KB) - added by elemoine 8 years ago.
geoext-213-2.patch (23.5 KB) - added by elemoine 8 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 8 years ago by ahocevar

  • Description modified (diff)

Changed 8 years ago by ahocevar

comment:2 Changed 8 years ago by ahocevar

  • Component changed from GeoExt to ux
  • State changed from None to Review

attachment:geoext-213.patch applies cleanly after the patch is #212 is applied. Patch comes with tests and example, both verified to work with FF3.5, IE7 and Chromium 4. Please review.

comment:3 Changed 8 years ago by aabt

Hi,

Would be good to have the same functionnality as in MapFish print widget*, adding/removing the associated layer when the panel is collapsed or deactivated:

comment:4 Changed 8 years ago by ahocevar

@aabt: feel free to provide an updated patch. It should not be too hard to do:

this.mapPanel.remove(this.printExtent);

to remove the extent, and

this.mapPanel.add(this.printExtent);

to add it again.

Changed 8 years ago by elemoine

comment:5 Changed 8 years ago by aabt

Hi,

Éric's patch needs an updated patch for #204 to be applied first(attached in ticket #204)

comment:6 Changed 8 years ago by ahocevar

Thanks elemoine for this enhancement. Looks good.

Changed 8 years ago by elemoine

comment:7 Changed 8 years ago by elemoine

  • State changed from Review to Needs more work

geoext-213-2.patch is based on patch geoext-204.5.patch of #204. Tests pass in FF3 and Chromium5.

Marking this as "Need More Work", as I'd like to do some more testing.

comment:8 Changed 8 years ago by elemoine

  • State changed from Needs more work to Commit

Tests pass in FF3, Chromium5 and IE8. ahocevar, please commit if you're happy with geoext-213-2.patch.

comment:9 Changed 8 years ago by ahocevar

  • Resolution set to fixed
  • Status changed from new to closed

(In [1877]) Added a form with interactive print extent to set up a print page. Thanks eleomine for making this work with the updated patch for #204. p=elemoine,me, r=elemoine,me (closes #213)

comment:10 Changed 8 years ago by elemoine

  • Milestone changed from 0.7 to ux
Note: See TracTickets for help on using tickets.