Opened 8 years ago

Last modified 8 years ago

#189 new enhancement

Street View Panel

Reported by: cmoullet Owned by:
Priority: major Milestone:
Component: ux Version: trunk
Keywords: Cc:
State: Review

Description

Create an Ext panel presenting Street View data. All information here: https://trac.geoext.org/wiki/ux/StreetViewPanel

Change History (3)

comment:1 Changed 8 years ago by cmoullet

  • Component changed from GeoExt to ux

comment:2 Changed 8 years ago by elemoine

Cédric,

The example is very cool!

A design-related comment: I think that the StreetViewPanel should just be a panel with a GStreetviewPanorama into it, and that other features should be implemented as plugins to the panel. I agree that the panel can be configured through options but the code of the panel could be simplified if features were implemented as plugins. (I guess the same comments could apply to the GoogleEarthPanel.)

More specific comments:

  • is there a reason for adding functions to the GStreetviewPanorama object instead of having functions in the panel prototype?
  • I think we should remove scriptSourceStreetView and rely on icon URL options
  • the control includes logic that belongs to the StreetViewPanel so I think we should make that control an inner class to the panel or something

comment:3 Changed 8 years ago by elemoine

  • Milestone 0.7 deleted
Note: See TracTickets for help on using tickets.