Ticket #180 (closed defect: fixed)

Opened 10 months ago

Last modified 9 months ago

check change event is fired twice

Reported by: bartvde Assigned to: ahocevar
Priority: major Milestone: 0.7
Component: GeoExt.tree.LayerNode Version: trunk
Keywords: Cc:
State: Commit

Description

the check change event is fired twice when changing a layer's visibility.

Attachments

geoext-180.patch (4.4 kB) - added by ahocevar on 11/25/09 14:53:59.

Change History

11/24/09 21:45:41 changed by bartvde

I can see this is caused by the call to GeoExt.tree.LayerNodeUI.superclass.toggleCheck.call(this, value); but simply removing this breaks a test for checkedGroup in LayerNode. Not sure how to handle this properly.

11/25/09 08:20:02 changed by ahocevar

  • owner set to ahocevar.

I will have a look. Thanks for the investigations so far.

11/25/09 14:53:59 changed by ahocevar

  • attachment geoext-180.patch added.

11/25/09 14:56:58 changed by ahocevar

  • state changed from None to Review.

Wow. There were some things badly wrong that I hadn't realized when I wrote the enforceOneVisible patch. Back then I just wondered about the need to manually set the checkbox state. And now finally I was able to resolve all this.

Tests still pass. Please review.

11/25/09 20:25:05 changed by tschaub

  • state changed from Review to Commit.

This is a very nice looking patch. Please commit.

11/25/09 20:36:08 changed by ahocevar

  • status changed from new to closed.
  • resolution set to fixed.

(In [1492]) Fixed an issue that manifested itself by the checkchange event being fired twice, along with some weirdness of having to set the checkbox state manually. All of this is now resolved. r=tschaub (closes #180)