Ticket #163 (closed defect: fixed)

Opened 10 months ago

Last modified 10 months ago

GetLegendGraphic request should use STYLE instead of STYLES

Reported by: bartvde Assigned to: bartvde
Priority: major Milestone: 0.6
Component: GeoExt.WMSLegend Version: trunk
Keywords: Cc:
State: Commit

Description

This came up in ticket:147, the GetLegendGraphic requests created by the LegendWMS component use the STYLES parameter, but the right parameter name is STYLE.

Attachments

ticket163.patch (5.8 kB) - added by bartvde on 10/09/09 10:25:24.
patch to fix this issue (depends on last patch of ticket:147)
163.patch (5.9 kB) - added by tschaub on 10/09/09 18:51:28.
style for legend

Change History

10/09/09 08:39:37 changed by bartvde

  • owner set to bartvde.

10/09/09 10:25:24 changed by bartvde

  • attachment ticket163.patch added.

patch to fix this issue (depends on last patch of ticket:147)

10/09/09 10:26:08 changed by bartvde

  • state changed from None to Review.

All tests pass in FF3.0 and IE6. Thanks for any review.

10/09/09 10:28:17 changed by bartvde

Somehow Trac preview is not showing the second part of the patch (downloading the patch works ok): lib/GeoExt/widgets/LegendWMS.js

10/09/09 18:51:28 changed by tschaub

  • attachment 163.patch added.

style for legend

10/09/09 18:52:07 changed by tschaub

  • state changed from Review to Commit.

Nothing significant changed in my patch. Just one that trac renders.

This looks good. Please commit.

10/09/09 19:03:31 changed by bartvde

Hey Tim, I can commit this on Monday morning (I still don't have a decent non-crashing patch utility for win32 to apply the patch). If that is too late, feel free to commit.

10/09/09 20:40:57 changed by tschaub

Hey Bart - My trip got pushed up a day and I'll be getting on a plane on Monday. I'd really like to kick out the release before that, so if you don't mind, I'll put this in. Thanks for the good work on it.

10/09/09 20:42:57 changed by tschaub

  • status changed from new to closed.
  • resolution set to fixed.

(In [1406]) Properly including the STYLE parameter (instead of STYLES) in GetLegendGraphic requests. Patch from Bart. r=me (closes #163)