Opened 7 years ago

Closed 7 years ago

#163 closed defect (fixed)

GetLegendGraphic request should use STYLE instead of STYLES

Reported by: bartvde Owned by: bartvde
Priority: major Milestone: 0.6
Component: GeoExt.WMSLegend Version: trunk
Keywords: Cc:
State: Commit

Description

This came up in ticket:147, the GetLegendGraphic requests created by the LegendWMS component use the STYLES parameter, but the right parameter name is STYLE.

Attachments (2)

ticket163.patch (5.8 KB) - added by bartvde 7 years ago.
patch to fix this issue (depends on last patch of ticket:147)
163.patch (5.9 KB) - added by tschaub 7 years ago.
style for legend

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by bartvde

  • Owner set to bartvde

Changed 7 years ago by bartvde

patch to fix this issue (depends on last patch of ticket:147)

comment:2 Changed 7 years ago by bartvde

  • State changed from None to Review

All tests pass in FF3.0 and IE6. Thanks for any review.

comment:3 Changed 7 years ago by bartvde

Somehow Trac preview is not showing the second part of the patch (downloading the patch works ok): lib/GeoExt/widgets/LegendWMS.js

Changed 7 years ago by tschaub

style for legend

comment:4 Changed 7 years ago by tschaub

  • State changed from Review to Commit

Nothing significant changed in my patch. Just one that trac renders.

This looks good. Please commit.

comment:5 Changed 7 years ago by bartvde

Hey Tim, I can commit this on Monday morning (I still don't have a decent non-crashing patch utility for win32 to apply the patch). If that is too late, feel free to commit.

comment:6 Changed 7 years ago by tschaub

Hey Bart - My trip got pushed up a day and I'll be getting on a plane on Monday. I'd really like to kick out the release before that, so if you don't mind, I'll put this in. Thanks for the good work on it.

comment:7 Changed 7 years ago by tschaub

  • Resolution set to fixed
  • Status changed from new to closed

(In [1406]) Properly including the STYLE parameter (instead of STYLES) in GetLegendGraphic requests. Patch from Bart. r=me (closes #163)

Note: See TracTickets for help on using tickets.