Ticket #150 (closed enhancement: fixed)

Opened 1 year ago

Last modified 1 year ago

LayerRecord should have consistent id when generated by LayerReader or WMSCapabilitiesReader

Reported by: bbinet Assigned to: bbinet
Priority: major Milestone: 0.6
Component: GeoExt.data.LayerRecord Version: trunk
Keywords: Cc:
State: Commit

Description

A LayerRecord generated by LayerReader will have the same id as OpenLayers layer.id, wereas a LayerRecord generated by WMSCapabilitiesReader will have an Ext generated id.

This behaviour is not consistent and I propose to adapt WMSCapabilitiesReader code similarly to LayerReader.

Path attached.

Attachments

patch_150-r1327-A0.diff (2.4 kB) - added by bbinet on 08/17/09 13:49:07.
patch_150-r1327-A1.diff (4.2 kB) - added by bbinet on 08/17/09 14:54:46.
add tests
patch_150-r1334-A2.diff (4.4 kB) - added by elemoine on 08/24/09 13:12:16.

Change History

08/17/09 13:49:07 changed by bbinet

  • attachment patch_150-r1327-A0.diff added.

08/17/09 14:54:46 changed by bbinet

  • attachment patch_150-r1327-A1.diff added.

add tests

08/17/09 14:59:02 changed by bbinet

  • state changed from None to Review.

patch_150-r1327-A1.diff adds tests to previous patch.

08/19/09 10:32:02 changed by bbinet

  • state changed from Review to None.

For information patch_150-r1327-A1.diff has been built once patch ticket 126 has been applied.

Moving state from "Review" to "None". Not ready for review as http://trac.geoext.org/ticket/126 is not closed.

08/24/09 13:12:16 changed by elemoine

  • attachment patch_150-r1334-A2.diff added.

08/24/09 13:13:23 changed by elemoine

patch_150-r1334-A2.diff is to applied atop patch_geoext_ticket126_r1332_A2.diff from #126.

09/29/09 15:58:08 changed by elemoine

  • state changed from None to Commit.

Patch looks good. Please commit once #126 is closed.

10/08/09 18:55:28 changed by tschaub

  • owner set to bbinet.

10/08/09 21:53:19 changed by bbinet

  • status changed from new to closed.
  • resolution set to fixed.

(In [1397]) LayerRecord should have consistent id when generated by LayerReader or WMSCapabilitiesReader. r=elemoine (closes #150)

10/13/09 23:30:54 changed by tschaub

  • component changed from GeoExt to GeoExt.data.LayerRecord.