Ticket #114 (closed defect: fixed)

Opened 1 year ago

Last modified 10 months ago

LayerNode should not change defaults on the UI

Reported by: bartvde Assigned to:
Priority: major Milestone: 0.6
Component: GeoExt.tree.LayerNode Version: trunk
Keywords: Cc:
State: Commit

Description

This is a sequel of ticket:113.

Currently the LayerNode changes defaults on the UI (eg to force it to render a checkbox), whereas the UI should do that.

Attachments

geoext_114.patch (1.6 kB) - added by bartvde on 07/09/09 14:51:30.
geoext-114.patch (2.5 kB) - added by ahocevar on 07/10/09 09:59:05.
using this.node.layer, because a.layer can just contain a string. Also added a test.

Change History

07/09/09 14:51:30 changed by bartvde

  • attachment geoext_114.patch added.

07/09/09 14:52:01 changed by bartvde

  • state changed from None to Review.

Andreas, is this what you had in mind?

07/10/09 09:59:05 changed by ahocevar

  • attachment geoext-114.patch added.

using this.node.layer, because a.layer can just contain a string. Also added a test.

07/10/09 10:00:19 changed by ahocevar

Thanks Bart, that's perfect, I only made one small change in my new patch and added a test. UIs that extend LayerNodeUI can now prevent checkboxes from being rendered by just setting checked = null before calling superclass.render. Please commit.

07/10/09 10:00:31 changed by ahocevar

  • state changed from Review to Commit.

07/10/09 14:37:26 changed by bartvde

  • status changed from new to closed.
  • resolution set to fixed.

(In [1246]) LayerNode should not change defaults on the UI, r=ahocevar, (closes #114)

10/13/09 23:51:15 changed by tschaub

  • type changed from enhancement to defect.