Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#114 closed defect (fixed)

LayerNode should not change defaults on the UI

Reported by: bartvde Owned by:
Priority: major Milestone: 0.6
Component: GeoExt.tree.LayerNode Version: trunk
Keywords: Cc:
State: Commit

Description

This is a sequel of ticket:113.

Currently the LayerNode changes defaults on the UI (eg to force it to render a checkbox), whereas the UI should do that.

Attachments (2)

geoext_114.patch (1.6 KB) - added by bartvde 8 years ago.
geoext-114.patch (2.5 KB) - added by ahocevar 8 years ago.
using this.node.layer, because a.layer can just contain a string. Also added a test.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by bartvde

comment:1 Changed 8 years ago by bartvde

  • State changed from None to Review

Andreas, is this what you had in mind?

Changed 8 years ago by ahocevar

using this.node.layer, because a.layer can just contain a string. Also added a test.

comment:2 Changed 8 years ago by ahocevar

Thanks Bart, that's perfect, I only made one small change in my new patch and added a test. UIs that extend LayerNodeUI can now prevent checkboxes from being rendered by just setting checked = null before calling superclass.render. Please commit.

comment:3 Changed 8 years ago by ahocevar

  • State changed from Review to Commit

comment:4 Changed 8 years ago by bartvde

  • Resolution set to fixed
  • Status changed from new to closed

(In [1246]) LayerNode should not change defaults on the UI, r=ahocevar, (closes #114)

comment:5 Changed 7 years ago by tschaub

  • Type changed from enhancement to defect
Note: See TracTickets for help on using tickets.