Changeset 1116

Timestamp:

06/19/09 17:15:04 (1 year ago)

Author:

tschaub

Message:

Removing the action's reference to the map. At some point, we may revisit this. It could be useful to have the map reference on the initalConfig. Since the initialConfig of a GeoExt.Action cannot currently be used to create another action, the properties there are not of any use. r=ahocevar (closes #99)

Files:

• core/trunk/geoext/lib/GeoExt/widgets/Action.js (modified) (2 diffs)
• core/trunk/geoext/tests/lib/GeoExt/widgets/Action.html (modified) (2 diffs)

core/trunk/geoext/lib/GeoExt/widgets/Action.js

@@ -48 +48 @@
-     *  been added to one, this config property may be omitted.
-     */
+    map: null,
-
-    /** private: property[uScope]
@@ -98 +99 @@
-            if(config.map) {
-                config.map.addControl(ctrl);
+                delete config.map;
-            }
-            ctrl.events.on({

core/trunk/geoext/tests/lib/GeoExt/widgets/Action.html

@@ -9 +9 @@
-    <script type="text/javascript">
-        function test_constructor(t) {
-1
+2
-
-            var ctrl, scope, handler, toggleHandler, checkHandler, cfg, action;
@@ -35 +35 @@
-            t.ok(action.control.map === map,
-                 "constructor adds control to map if provided");
+            t.ok(!action.initialConfig.map,
+                 "action does not have a reference to the map");
-            t.ok(action.uScope == scope,
-                 "constructor sets this.uScope to user-provided scope");